Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(subnets): make the MAC address of a reserved IP required and immutable MAASENG-3914 #5548

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

r00ta
Copy link
Contributor

@r00ta r00ta commented Oct 22, 2024

Done

  • make the MAC address of a reserved IP required and immutable

QA steps

  • create a reserved IP -> ensure that the MAC address is required
  • modify the reserved IP -> ensure the text box of the MAC address is disabled

Screenshots

MAC address is required
MAC address is required error
MAC address text box is disabled

@webteam-app
Copy link

Copy link
Contributor

@ndv99 ndv99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor (optional) nitpicks below

Thanks for the PR! You're officially a full-stack dev now 😉

r00ta and others added 2 commits October 22, 2024 10:48
…PLease/ReserveDHCPLease.tsx

Co-authored-by: Nick De Villiers <nick.devilliers@canonical.com>
…PLease/ReserveDHCPLease.test.tsx

Co-authored-by: Nick De Villiers <nick.devilliers@canonical.com>
@r00ta r00ta merged commit ed3cdb9 into canonical:main Oct 22, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants